Nuke BasicModel legacy constructor and fix `NonDimensionalMode…
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashbire1
approved these changes
Oct 23, 2019
glwagner
approved these changes
Oct 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 73.31% 73.46% +0.15%
==========================================
Files 27 27
Lines 1525 1515 -10
==========================================
- Hits 1118 1113 -5
+ Misses 407 402 -5
Continue to review full report at Codecov.
|
ali-ramadhan
changed the title
BasicModel legacy constructor and fix NonDimensionalModel constructorBasicModel legacy constructor and fix `NonDimensionalMode…
Merged
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR nukes the
BasicModellegacy constructor to avoid potential confusion.I also made the
NonDimensionalModelconstructor act more like theModelconstructor. Also fixed a typo there and added a test.Resolves #429