Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(compress): add lz4hc support #401

Merged
merged 1 commit into from
May 22, 2024

Conversation

tomershafir
Copy link
Contributor

@tomershafir tomershafir commented Apr 27, 2024

Summary

Add compression method LZ4HC to native writes. Decompression shouldn't be affected.

  • This patch changes compress.Method actual values, as I assume clients dont depend on that.
  • Feel free to reorder ch.Compression and move LZ4HC next to LZ4, based on assumption similar to the above, and rerun go generate.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@tomershafir tomershafir changed the title compress: add lz4hc support feat: add lz4hc compression support Apr 28, 2024
@tomershafir tomershafir changed the title feat: add lz4hc compression support feat(compress): add lz4hc support Apr 28, 2024
@tomershafir tomershafir force-pushed the compress-add-lz4hc branch 3 times, most recently from bf828e4 to 953edc7 Compare April 28, 2024 10:26
@ernado ernado merged commit d4dca7a into ClickHouse:main May 22, 2024
23 checks passed
@tomershafir tomershafir deleted the compress-add-lz4hc branch May 22, 2024 05:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants