Merge pull request #1 from gfoiani/master

Drop view retro compatibility for SQL Server 2012
ClickMechanic · Nov 21, 2018 · 2830748 · 2830748
2 parents 23182c2 + a4c8c76
commit 2830748
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/scenic/adapters/sql_server.rb b/lib/scenic/adapters/sql_server.rb
@@ -20,7 +20,7 @@ def update_view(name, sql)
       end
 
       def drop_view(name)
-        execute "DROP VIEW IF EXISTS #{quote_table_name(name)};"
+        execute "IF OBJECT_ID('#{quote_table_name(name)}') IS NOT NULL DROP VIEW #{quote_table_name(name)};"
       end
 
       class NotSupportedError < StandardError

diff --git a/lib/scenic_sqlserver_adapter/version.rb b/lib/scenic_sqlserver_adapter/version.rb
@@ -1,3 +1,3 @@
 module ScenicSqlserverAdapter
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end
diff --git a/spec/scenic/adapters/sql_server_spec.rb b/spec/scenic/adapters/sql_server_spec.rb
@@ -40,7 +40,7 @@ module Adapters
 
         describe 'drop_view' do  
           it 'executes DROP VIEW SQL on the connection' do
-            expect(connection).to receive(:execute).with('DROP VIEW IF EXISTS [to_a_kill];')
+            expect(connection).to receive(:execute).with("IF OBJECT_ID('[to_a_kill]') IS NOT NULL DROP VIEW [to_a_kill];")
             subject.drop_view('to_a_kill')
           end
         end