Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove log with database connection string #123

Merged
merged 3 commits into from
May 10, 2023
Merged

Remove log with database connection string #123

merged 3 commits into from
May 10, 2023

Conversation

seallard
Copy link
Contributor

@seallard seallard commented May 10, 2023 •
edited
Loading

Description

This PR removes a log message containing database connection strings.

Fixed

  • Remove log with database connection string

This version is a:

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ChrOertlin
ChrOertlin approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@seallard seallard merged commit 1bd68f8 into master May 10, 2023
@seallard seallard deleted the remove-log-of-database-connection-string branch May 10, 2023 09:55
@seallard
Copy link
Contributor Author

Deployed to stage and prod.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChrOertlin ChrOertlin ChrOertlin approved these changes

@henrikstranneheim henrikstranneheim Awaiting requested review from henrikstranneheim

@Vince-janv Vince-janv Awaiting requested review from Vince-janv

@diitaz93 diitaz93 Awaiting requested review from diitaz93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seallard @ChrOertlin