Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Functionality for updating archiving/retrieval task ids #132

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

islean
Copy link
Contributor

@islean islean commented Aug 9, 2023

Description

When retrieving archived files and rearchiving them, there is a need to update both the retrieval_task_id and archiving_task_id fields in the corresponding entry in the Archive table. This PR addresses that.

Added

  • Method update_retrieval_task_id.
  • Method update_archiving_task_id.
  • Tests for both methods.

Testing

How to prepare for test

  • ssh to hasta (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_main -t housekeeper -b update_archive_entries

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@islean islean self-assigned this Aug 9, 2023
@islean islean changed the title Functionality for updating archiving/retrival task ids Functionality for updating archiving/retrieval task ids Aug 9, 2023
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,!

housekeeper/store/api/handlers/update.py Outdated Show resolved Hide resolved
housekeeper/store/api/handlers/update.py Outdated Show resolved Hide resolved
housekeeper/store/api/handlers/update.py Outdated Show resolved Hide resolved
Co-authored-by: ChristianOertlin <c.oertlin@gmail.com>
Co-authored-by: ChristianOertlin <c.oertlin@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@islean
Copy link
Contributor Author

islean commented Aug 10, 2023

Deployment to stage went fine and functionality will be tested from cg.

repository is clean
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/isak.ohlsson
done.
Log deploy... done.
housekeeper, version 4.6.0

@islean islean merged commit 6baff98 into master Aug 10, 2023
@islean islean deleted the update_archive_entries branch August 10, 2023 08:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants