Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(Archiving) Filter on tags in get_retrieved_files #189

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 9, 2024

Description

This PR adds support for filtering on tags when getting retrieved files.

Added

  • Tag filtering in get_retrieved_files

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
housekeeper-test-deploy archiving-filter-on-tags
housekeeper-test <command here>

Any migrations need to be applied manually with alembic against the stage database.

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@islean islean requested a review from a team as a code owner January 9, 2024 11:58
@islean
Copy link
Contributor Author

islean commented Jan 9, 2024

Deployed to stage and the CLI was responsive. Since no live code is affected, testing is deemed succesful.

@islean islean self-assigned this Jan 9, 2024
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@islean islean merged commit c13d556 into master Jan 9, 2024
@islean islean deleted the archiving-filter-on-tags branch January 9, 2024 15:00
@islean
Copy link
Contributor Author

islean commented Jan 9, 2024

Deployed to production:

Writing manifest to image destination
Storing signatures
INFO:    Creating SIF file...
INFO:    Build complete: /home/proj/stage/singularity_containers/housekeeper_temp.sif
Successfully pulled the latest Housekeeper image.
1d [isak.ohlsson@hasta:~] [base] 16s $ 

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants