Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed generator specs and added migration version #292

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

emptyflask
Copy link
Contributor

Rails 5.x expects migrations to subclass ActiveRecord::Migration[5.x]

@seuros
Copy link
Member

seuros commented Dec 6, 2017

Thank you @emptyflask for this fix.
It will break in rails 4.2 :(

let me think about a solution

@emptyflask
Copy link
Contributor Author

Will it? Under Rails 4, the version should just be nil. Or will it fail for some other reason?

@seuros
Copy link
Member

seuros commented Dec 6, 2017

You sure ? I think it will be ActiveRecord::Migration4

@seuros seuros merged commit dc464ac into ClosureTree:master Dec 6, 2017
@seuros
Copy link
Member

seuros commented Dec 6, 2017

Nevermind. It works 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants