Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #264 #306

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Fix #264 #306

merged 1 commit into from
Apr 26, 2018

Conversation

n-rodriguez
Copy link
Contributor

No description provided.

@n-rodriguez n-rodriguez changed the title Fix https://github.com/ClosureTree/closure_tree/issues/264 Fix #264 Apr 17, 2018
@grk
Copy link
Contributor

grk commented Apr 18, 2018

This doesn't work for me. Somehow, quoted_hierarchy_table_name gets cached and the generated SQL includes ORDER BY .generations ASC which fails.

@n-rodriguez
Copy link
Contributor Author

@@ -17,6 +17,9 @@ def order_option?
end

def order_is_numeric?
# return if not connected to DB (on rake db:setup for instannce)
Copy link
Member

@seuros seuros Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# skip if database is not connected.

@seuros seuros merged commit 3b945f5 into ClosureTree:master Apr 26, 2018
@seuros
Copy link
Member

seuros commented Apr 26, 2018

Thank you

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants