Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix https://github.com/ClosureTree/closure_tree/issues/308 #311

Merged
merged 1 commit into from
May 25, 2018
Merged

Fix https://github.com/ClosureTree/closure_tree/issues/308 #311

merged 1 commit into from
May 25, 2018

Conversation

n-rodriguez
Copy link
Contributor

No description provided.

@n-rodriguez n-rodriguez mentioned this pull request May 25, 2018
Closed
@seuros seuros merged commit 6fcfe12 into ClosureTree:master May 25, 2018
@n-rodriguez n-rodriguez deleted the wip/rework_numeric branch May 25, 2018 22:08
@mceachen
Copy link
Collaborator

Nice! I think this is a good change (I wish I'd thought of it). We need to bump the major version for this and probably add a bit of documentation.

@n-rodriguez
Copy link
Contributor Author

Well I've updated the README : https://github.com/ClosureTree/closure_tree#deterministic-ordering.
Maybe we should add something in the CHANGELOG to warn users about this change.

@mceachen
Copy link
Collaborator

+1 to the CHANGELOG, and probably a note in that section saying

PLEASE NOTE: versions prior to 7.0.0 tried to be "clever" and inferred deterministic ordering based on the schema, but this was problematic. Versions 7.0 and later require setting numeric_order explicitly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-rodriguez @mceachen @seuros