Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Call Module#module_parent instead of deprecated #parent #354

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Call Module#module_parent instead of deprecated #parent #354

merged 1 commit into from
Jan 13, 2020

Conversation

grk
Copy link
Contributor

@grk grk commented Oct 22, 2019

Solves Rails 6 deprecation warning.

Opening a duplicate PR as #349 seems stale.

Fixes #346.

@oskarlakner
Copy link

Please merge it finally! :)

abrom added a commit to Studiosity/closure_tree that referenced this pull request Nov 15, 2019
@simi
Copy link

simi commented Dec 22, 2019

Is there anything I can help with in here to get this merged and released?

@seuros seuros merged commit af7d761 into ClosureTree:master Jan 13, 2020
@marckohlbrugge
Copy link

@seuros Thanks for merging this 🥳

@grk grk deleted the rails-6-module-parent branch April 3, 2020 13:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module#parent is deprecated in Rails 6 and will be removed in Rails 6.1
6 participants