-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! As stated in the PR description, we will just move forward with the "old trigger design" as it currently works fine anyway.
@l3uddz I performed the usual "go test ./..." and manual testing with a http client to make sure the router works correctly. I'm not sure if you're using Readarr (I doubt it) but I'd love some real-world testing. Perhaps we can launch a separate Docker tag for a couple of weeks?
l.Info(). | ||
Str("path", scans[0].Folder). | ||
Str("event", event.Type). | ||
Msg("Scan moved to processor") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3uddz unsure if this logic is sound, but it's inline with how the Lidarr trigger approaches it.
@l3uddz could you have a look at CI? 😅 |
We've decided to merge this PR into a temporary |
Co-authored-by: voltron4lyfe <55123373+voltron4lyfe@users.noreply.github.com> Co-authored-by: l3uddz <l3uddz@gmail.com>
Picking up adding Readarr support from @rg9400's original . (I checked with him on Discord). Adds basic Readarr support by supporting the Download event. Future PR's will be needed to add support for Delete and Rename events.
There was discussion on the original a new router architecture but my understanding of the original PR discussion was that this should move forward and we can figure out how to move this (and other *arr hooks) to the new architecture.
Closes #128, closes #143.