This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
fix(trigger/bernard): dont try and retrieve the folder path for a drive id #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l3uddz
added
triggers
m-rots
approved these changes
Aug 10, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Any file creates/changes in the root of a drive, would cause the partial sync to fail while trying to retrieve a folder for it.
This would ultimately fail 5 times before the drive is stopped being monitored.
Fix
Do not lookup folder paths where the driveId == folderId.
Misc
Update stubbs to v1.1.0.
Some changes to the error messages bernard produces.