Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: Make ipc test more portable #466

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

chrissie-c
Copy link
Contributor

fix a couple of errors reported by covscan

  1. /usr/lib64/libqb/tests/resources.test:8:34: warning[SC2039]: In POSIX sh, UID is undefined.
  2. /usr/lib64/libqb/tests/resources.test:8:30: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
  3. /usr/lib64/libqb/tests/ipc_sock.test:10:34: warning[SC2039]: In POSIX sh, UID is undefined.
  4. /usr/lib64/libqb/tests/ipc_sock.test:10:30: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

fix a couple of errors reported by covscan

1. /usr/lib64/libqb/tests/resources.test:8:34: warning[SC2039]: In POSIX sh, UID is undefined.
1. /usr/lib64/libqb/tests/resources.test:8:30: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
1. /usr/lib64/libqb/tests/ipc_sock.test:10:34: warning[SC2039]: In POSIX sh, UID is undefined.
1. /usr/lib64/libqb/tests/ipc_sock.test:10:30: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
@fabbione
Copy link
Member

fabbione commented Jun 8, 2022

ack

@chrissie-c
Copy link
Contributor Author

The new code covscan warnings can be waived.

  1. rand() is called in a test program that's is nothing to do with crypto
  2. max_msg_size can never be -1 or it's unsigned equivalent unless the user explicitly makes it so with a library call.

@chrissie-c chrissie-c merged commit 44a4cb2 into ClusterLabs:main Jun 8, 2022
@chrissie-c chrissie-c deleted the stdshell branch June 8, 2022 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants