-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Include non-shared schemes in Project.schemes #680
base: master
Are you sure you want to change the base?
Conversation
Please add a test? |
@dnkoutso Done. |
@dnkoutso ping |
CHANGELOG.md
Outdated
@@ -16,6 +16,9 @@ | |||
* Generating deterministic UUIDs for a project also updates `TargetAttributes`. | |||
[Samuel Giddins](https://github.com/segiddins) | |||
|
|||
* Include non-shared schemes in `Project.schemes`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing 2 empty spaces after the period. Also move this up to master section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean rebase your branch cause I think 1.9.0 has been released.
Hi there, I ran into a problem using Xcodeproj as part of fastlane (fastlane/fastlane#14988). When running schemes on a project that was generated with CMake and never opened with Xcode GUI (like in the context of a CI server), the method Xcodeproj::Project.schemes(path) doesn't actually returns the availables schemes as the files have not been created. Maybe a better way would be to parse the output of
|
The |
Then we can merge this. |
ping @lebedev |
@dnkoutso do we have an estimate when can we expect this ? |
It will ship with 1.12.1 in a week or two. |
@lebedev if you'd like this change to land can you please rebase your branch against |
@lebedev I rebased your branch & moved the changelog to the right place |
Hi!
I've discovered that getting schemes for modern projects fails if scheme name differs from project name due to wrong paths. E.g. I have a.xcscheme
file located at./Pods.xcodeproj/xcuserdata/USERNAME.xcuserdatad/xcschemes/Firebase.xcscheme
, whereUSERNAME
is a username of my user. However, currentXcodeproj
looks for.xcscheme
files only atproject_path/xcshareddata/xcschemes/*.xcscheme
.To fix that I've added**
there. This change should support both old and new paths.I've discovered that getting schemes for a project doesn't consider non-shared schemes.
To fix that I've added
**
there. This change should support both shared and non-shared schemes.