Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: bump actions/checkout to v4 #47

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

fargito
Copy link
Member

@fargito fargito commented Sep 30, 2024

No description provided.

@fargito fargito requested a review from art049 September 30, 2024 12:55
@fargito fargito self-assigned this Sep 30, 2024
@fargito fargito force-pushed the chore/actions-checkout-v4 branch from 04c33e2 to f7999ae Compare September 30, 2024 12:56
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #47 will degrade performances by 41.01%

Comparing chore/actions-checkout-v4 (f7999ae) with master (d1c3db8)

Summary

⚡ 4 improvements
❌ 4 (👁 4) regressions
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark master chore/actions-checkout-v4 Change
👁 test_hostname_resolution[google.com] 70.5 µs 114.6 µs -38.47%
👁 test_multiprocessing_map[100000] 96 ms 102.1 ms -5.95%
test_multiprocessing_map[10000] 16.3 ms 12 ms +35.47%
test_multiprocessing_map[1000] 7.1 ms 6 ms +18.99%
test_multiprocessing_map[100] 4.9 ms 3.6 ms +33.75%
👁 test_multiprocessing_map[10] 2.8 ms 3.1 ms -10.42%
test_open_close_fd[10] 37.2 µs 36.1 µs +2.8%
👁 test_tcp_connection[google.com-443] 64.2 µs 108.9 µs -41.01%

Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to ignore those new syscall heavy benches

@fargito fargito merged commit 2adda63 into master Sep 30, 2024
22 checks passed
@fargito fargito deleted the chore/actions-checkout-v4 branch September 30, 2024 16:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants