Store benchmark metadata data in results.json
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Instrumentation Performance ReportMerging #63 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
adriencaccia
force-pushed
the
cod-429-update-pytest-codspeed-to-store-benchmark-metadata-data-in
branch
from
fbae262 to
1ad4aa9
Compare
fargito
approved these changes
Jan 14, 2025
adriencaccia
changed the title
results.json
art049
requested changes
Jan 16, 2025
Comment on lines
+53
to
+80
| @property | ||
| def display_name(self) -> str: | ||
| if len(self.args) == 0: | ||
| args_str = "" | ||
| else: | ||
| arg_blocks = [] | ||
| for i, (arg_name, arg_value) in enumerate(zip(self.args_names, self.args)): | ||
| arg_blocks.append(arg_to_str(arg_value, arg_name, i)) | ||
| args_str = f"[{'-'.join(arg_blocks)}]" | ||
|
|
||
| return f"{self.name}{args_str}" | ||
|
|
||
| def to_json_string(self) -> str: | ||
| return json.dumps( | ||
| self.__dict__, default=vars, separators=(",", ":"), sort_keys=True | ||
| ) | ||
|
|
||
|
|
||
| def arg_to_str(arg: Any, arg_name: str, index: int) -> str: | ||
| if type(arg) in [int, float, str]: | ||
| return str(arg) | ||
| if ( | ||
| arg is not None | ||
| and type(arg) not in [list, dict, tuple] | ||
| and hasattr(arg, "__str__") | ||
| ): | ||
| return str(arg) | ||
| return f"{arg_name}{index}" |
There was a problem hiding this comment.
Before merging, we need to make sure we know the difference with the display name computation from pytest itself (and the potential impact)
|
|
||
| config: BenchmarkConfig | ||
| stats: BenchmarkStats | ||
| class WalltimeBenchmark(Benchmark): |
There was a problem hiding this comment.
is it essential to inherit here?
There was a problem hiding this comment.
That way we do not have to define the properties twice
There was a problem hiding this comment.
I meant It's weird to inherit from a metadata class
There was a problem hiding this comment.
Seen together, let's do composition instead of inheritance, by having a new field benchmark_metadata: BenchmarkMetadata
Use json reprensation as benchmark identifier in valgrind instrumentation
adriencaccia
force-pushed
the
cod-429-update-pytest-codspeed-to-store-benchmark-metadata-data-in
branch
from
1ad4aa9 to
ef62849
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
results.jsonfile containing benchmark metadata for all instruments, and update the valgrind trigger to contain all the metadata.