Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use proper iterations times and fix round sizes #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

art049
Copy link
Member

@art049 art049 commented Jan 28, 2025

  • fix: use time per iteration instead of total round time in stats
  • feat: increase the min round time to a bigger value (+/- 1ms)

@art049 art049 force-pushed the cod-505-use-correct-timings-in-pytest-codspeed-walltime branch from 5468412 to 325cb00 Compare January 28, 2025 11:09
@art049 art049 requested a review from adriencaccia January 28, 2025 11:09
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Instrumentation Performance Report

Merging #67 will improve performances by 3.05%

Comparing cod-505-use-correct-timings-in-pytest-codspeed-walltime (bec227d) with master (003c3b4)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_combination_lists[5-4] 28.7 µs 27.9 µs +3.05%

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Walltime Performance Report

Merging #67 will degrade performances by 5%

Comparing cod-505-use-correct-timings-in-pytest-codspeed-walltime (bec227d) with master (003c3b4)

Summary

⚡ 33 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iir_filter_process 3 µs 2.7 µs +9.89%
test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 852 ns 617.9 ns +37.89%
test_make_allpass 5.2 µs 4.7 µs +10.63%
test_make_bandpass 5.5 µs 4.9 µs +11.15%
test_make_highpass 5.7 µs 5 µs +13.52%
test_make_highshelf 7.4 µs 6.6 µs +12.06%
test_make_lowpass 5.7 µs 4.9 µs +15.17%
test_make_lowshelf 7.2 µs 6.5 µs +11.52%
test_make_peak 6.4 µs 5.7 µs +13.24%
test_color[graph0-3] 27.1 µs 25.7 µs +5.54%
test_combination_lists[0-0] 1.9 µs 1.5 µs +28.36%
test_combination_lists[4-2] 3.6 µs 3.3 µs +10%
test_combination_lists[5-4] 3.4 µs 3 µs +12.94%
test_generate_all_combinations[0-0] 1,212 ns 867.7 ns +39.68%
test_generate_all_combinations[4-2] 5.9 µs 5.6 µs +5.88%
test_generate_parenthesis[3] 7.8 µs 7.4 µs +4.87%
test_get_valid_pos[pos0-4] 2.8 µs 2.5 µs +16.02%
test_hamilton_cycle[graph0] 23.9 µs 23.2 µs +2.76%
test_is_complete[board0] 1.8 µs 1.3 µs +35.16%
test_is_safe[board0-1-1] 10.1 µs 9.3 µs +8.72%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@adriencaccia
Copy link
Member

Let's merge #65 before this one, so that the reports will work correctly

@art049 art049 force-pushed the cod-505-use-correct-timings-in-pytest-codspeed-walltime branch from 325cb00 to 4333c1f Compare January 28, 2025 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants