Skip to content

@graphql-codegen/typescript v4 breaks package #373

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
elijaholmos opened this issue May 24, 2023 · 3 comments · Fixed by #375
Closed

@graphql-codegen/typescript v4 breaks package #373

elijaholmos opened this issue May 24, 2023 · 3 comments · Fixed by #375

Comments

@elijaholmos
Copy link
Contributor

elijaholmos commented May 24, 2023 •
edited
Loading

as you can see by the latest dep update 55277f1, tests are failing due to breaking changes in the @graphql-codegen/typescript packages. I am also experiencing this in my local project; specifically, what was previously parsed as z.string() is now parsed as definedNonNullAnySchema:

image

(v3 on the right, v4 on the left)
@elijaholmos elijaholmos changed the title graphql-codegen v4 breaks package @graphql-codegen/typescript v4 breaks package May 24, 2023
@valerii15298
Copy link

valerii15298 commented May 26, 2023 •
edited
Loading

I have the same issue!!
Downgrading to "@graphql-codegen/typescript": "^3.0.0", solves the issue

@Code-Hex
Copy link
Owner

@elijaholmos Thanks!
I think this problem is caused by this breaking change dotansimha/graphql-code-generator#9375

I will fix this asap 🙏

Code-Hex added a commit that referenced this issue May 27, 2023
@Code-Hex
added own visitor and fixed build error for #373
ba0eee0
@Code-Hex Code-Hex mentioned this issue May 27, 2023
Merged
@Code-Hex
Copy link
Owner

@elijaholmos @valerii15298 I just published the latest version for this.

Unfortunately, I couldn't maintain backward-compatible between @graphql-codegen/typescript v3 and v4. So you guys are required to do action to solve this problem 🙏

Please my release note: https://github.com/Code-Hex/graphql-codegen-typescript-validation-schema/releases/tag/v0.10.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 373 Code-Hex/graphql-codegen-typescript-validation-schema
3 participants
@Code-Hex @elijaholmos @valerii15298