Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

updated references.md and files.md #5535

Closed
wants to merge 8 commits into from

Conversation

Naumantamboli
Copy link
Contributor

Description

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [✓] All writings are my own.
  • [✓] My entry follows the Codecademy Docs style guide.
  • [✓] My changes generate no new warnings.
  • [✓] I have performed a self-review of my own writing and code.
  • [✓] I have checked my entry and corrected any misspellings.
  • [✓] I have made corresponding changes to the documentation if needed.
  • [✓] I have confirmed my changes are not being pushed from my forked main branch.
  • [✓] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [✓] I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Oct 21, 2024
@mamtawardhani
Copy link
Collaborator

Hey @Naumantamboli
So, as I can see you have been assigned to two issues - #5490 and #5485
You will have to raise two different PRs for both issues. Additionally, you will have to create a separate feature branch and edit the content on that branch for each PR. Your current PR is on the main branch, and it will not be merged due to that.

So, please raise 2 new PRs with two feature branches, one for each PR. Also, you are not following the issue description - Both the issues want you to shorten the description of the entry, you have rather added new content. Please stick to the issue description.

Closing this PR, as it is on the main branch, thank you! 😃

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants