Fix info.json keys in approved CC guide #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flame442
added
the
Type: Bug
github-actions
bot
added
Category: Docs - For Developers
Arguable - it's still an existing convention to put cog's class name in the |
Jackenmen
approved these changes
Jul 10, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Jul 11, 2024
thanks Redbot team * Docs: remove Atom from the list of recommended editors (Cog-Creators#6388) * Fix info.json keys in approved CC guide (Cog-Creators#6382) * Use YouTube source plugin over the deprecated built-in source (Cog-Creators#6373) Co-authored-by: aikaterna <20862007+aikaterna@users.noreply.github.com> * Bump d.py version to 2.4.0 (Cog-Creators#6401) Co-authored-by: Ryan <yamikaitou@gmail.com> * Fix `@commands.can_manage_channel` always passing (Cog-Creators#6398) * Bump dependencies (Cog-Creators#6402) * Red 3.5.10 - Changelog (Cog-Creators#6403) * Automated Crowdin downstream (Cog-Creators#6405) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.10 (Cog-Creators#6404) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Last-minute changelog fixes * Version bump to 3.5.11.dev1 (Cog-Creators#6406) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Seaswimmer <102361830+SeaswimmerTheFsh@users.noreply.github.com> Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com> Co-authored-by: Jakub Kuczys <me@jacken.men> Co-authored-by: aikaterna <20862007+aikaterna@users.noreply.github.com> Co-authored-by: Ryan <yamikaitou@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Like many people, I simply referenced other people's cogs to make my
info.jsons, and an extra phantom key from the V2 days made its way into our docs. I removed thenamekey from both the repo and cog requirements, and added the conditionalmin_python_versionkey since lots of cogs lately have needed that one.Technically the cookie cutter repo and the policies should also be updated, but I don't want to do that :(
Have the changes in this PR been tested?
Yes