Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lines around Qlabel in v2.6.8 & Python 3.7 #163

Closed
kosayoda opened this issue May 6, 2019 · 10 comments
Closed

Lines around Qlabel in v2.6.8 & Python 3.7 #163

kosayoda opened this issue May 6, 2019 · 10 comments
Assignees
Labels
Milestone

Comments

@kosayoda
Copy link

kosayoda commented May 6, 2019

Environment

  • QDarkStyle: 2.6.8
  • OS: Linux 4.15.0-48-generic x86_64
  • Python: 3.7.2.final.0
  • PySide2: 5.12.3

qdarkstyle --all throws an error, see #162

Language

Python

Actual Result

Screenshot from 2019-05-06 14-40-49

Looks like #141 except the current version is 2.6.8, please advise if it's intended

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

It should be not like this. Could you provide your code or at least the nesting of items until the QLabel? Tks

@dpizetta dpizetta added this to the 2.7 milestone May 6, 2019
@dpizetta dpizetta added the bug label May 6, 2019
@dpizetta dpizetta self-assigned this May 6, 2019
@kosayoda
Copy link
Author

kosayoda commented May 6, 2019

The .ui file is generated using QtDesigner, then converted to a .py file. The Qt Designer Object Inspector looks like this:

Screenshot from 2019-05-06 19-53-09

My code looks like this (relevant portions):

class MainApplication(QMainWindow):
    def __init__(self):
        super().__init__()
        self.ui = ui.MainWindow()  # the generated Ui_MainWindow class
        self.ui.setupUi(self)

def main():
    app = QApplication(sys.argv)
    app.setStyleSheet(qdarkstyle.load_stylesheet_pyside2())
    window = MainApplication()
    window.show()
    sys.exit(app.exec_())

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

@goanpeca is the _style.scss updated with the last changes in style.qss? If so, I'll start to use it to not change the qss manually.

To fix this may we need to use ".QFrame" instead of QFrame that includes descendants, including QLabel.

@goanpeca
Copy link
Collaborator

goanpeca commented May 6, 2019

@dpizetta if you have qtsass installed then we should only work with the _style.scss file (which should include all the latest changes I found)

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

@goanpeca Should I use the version 0.2.2 alpha from release or from master as it is not available on pypi yet?

@goanpeca
Copy link
Collaborator

goanpeca commented May 6, 2019

this one is fine https://pypi.org/project/qtsass/

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

I was not up to date :) Tks

@dpizetta
Copy link
Collaborator

@kosayoda could you test this branch? Remember to remove the old installation before. Tks

git clone -b fix-qlabel-lines-frame https://github.com/ColinDuquesnoy/QDarkStyleSheet.git qdark-fix-qlabel

@kosayoda
Copy link
Author

Was testing it just as this issue got closed, just commenting for posterity.
I can confirm that the branch fixes the issue. Thank you for the fix.

@dpizetta
Copy link
Collaborator

Tks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants