QComboBox expands the last chosen item #200

jkulskis · 2019-07-12T02:52:49Z

Describe Your Environment

Please, report the output of the command (from v2.6+):

$ qdarkstyle --all

* OPERATING SYSTEM---------------------------------------------------------------
    - System........................ Linux
    - Release....................... 4.15.0-20-generic
    - Platform...................... Linux-4.15.0-20-generic-x86_64-with-LinuxMint-19.1-tessa
    - Version....................... #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018
* PYTHON DISTRIBUTION------------------------------------------------------------
    - Version....................... 3.6.8
    - C Compiler.................... GCC 8.0.1 20180414 (experimental) [trunk revision 259383
    - C API Version................. 1013
    - Implementation................ cpython
    - Implementation Version........ 3.6.8
* QT BINDINGS--------------------------------------------------------------------
    - PySide2 Version............... 5.13.0
    - PySide2 Qt Version............ 5.13.0
* QT ABSTRACTIONS----------------------------------------------------------------
    - Status........................ No Qt abstractions available!
* PYTHON PACKAGES----------------------------------------------------------------
    - helpdev....................... (0.6.10)
    - QDarkStyle.................... (2.7)

[Versions from your environment]

QDarkStyle: 2.7
OS: Linux Mint 19.1 Tessa
Python: 3.6.8
PySide2: 5.13

Language

Python

Description / Steps to Reproduce [if necessary]

Relevant UI setup code I used to add the combo box (generated by pyuic5) with a Dialog creation to provide a reproducible example:

from PySide2 import QtCore, QtGui, QtWidgets
import qdarkstyle
import sys

class Ui_Dialog(object):
    def setupUi(self, Dialog):
        Dialog.setObjectName("Dialog")
        Dialog.resize(875, 527)
        self.comboBox = QtWidgets.QComboBox(Dialog)
        self.comboBox.setObjectName("comboBox")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.comboBox.addItem("")
        self.retranslateUi(Dialog)
        self.comboBox.setCurrentIndex(4)
        QtCore.QMetaObject.connectSlotsByName(Dialog)

    def retranslateUi(self, Dialog):
        _translate = QtCore.QCoreApplication.translate
        Dialog.setWindowTitle(_translate("Dialog", "Dialog"))
        self.comboBox.setItemText(0, _translate("Dialog", "1 day"))
        self.comboBox.setItemText(1, _translate("Dialog", "1 week"))
        self.comboBox.setItemText(2, _translate("Dialog", "3 months"))
        self.comboBox.setItemText(3, _translate("Dialog", "6 months"))
        self.comboBox.setItemText(4, _translate("Dialog", "1 year"))
        self.comboBox.setItemText(5, _translate("Dialog", "3 years"))
        self.comboBox.setItemText(6, _translate("Dialog", "5 years"))
        self.comboBox.setItemText(7, _translate("Dialog", "max"))

class Dialog(QtWidgets.QDialog):
    def __init__(self):
        super(Dialog, self).__init__()
        self.ui = Ui_Dialog()
        self.ui.setupUi(self)

if __name__ == "__main__":
    app = QtWidgets.QApplication(sys.argv)
    window = Dialog()
    window.show()
    app.setStyleSheet(qdarkstyle.load_stylesheet_pyside2())
    sys.exit(app.exec_())

When I open up the combobox, the item that was last chosen will increase in size as shown in the image below:

I tried to revert back to the default qt theme, and everything worked fine. I suspect it has something to do with Linux Mint or other aspects of my environment since I asked a question on StackOverflow, and a user commented that the code worked fine for them on linux.

The text was updated successfully, but these errors were encountered:

goanpeca · 2019-07-12T04:11:23Z

@jkulskis could you try doing something like setting a styled delegate for the combo box?

from PySide2 import QtCore, QtGui, QtWidgets
...
    delegate = QStyledItemDelegate()
    self.comboBox = QtWidgets.QComboBox(Dialog)
    self.comboBox.setItemDelegate(delegate)

jkulskis · 2019-07-12T04:37:08Z

@goanpeca This fixed the extra expansion, but now the combobox opens much higher than the dialog window instead of as a dropdown.

Unopened:

Opened:

goanpeca · 2019-07-12T04:53:08Z

Ok! We will see how we can fix that. Thanks for testing.

jkulskis · 2019-07-12T04:56:54Z

Thank you for the quick help!

cculianu · 2019-08-17T10:38:54Z

Note this also happens on macOS -- same thing. Screenshot attached.

It doesn't happen with PyQt5 5.12.x, but happens only starting with PyQt5 5.13.x.

So the issue is not PySide-specific nor PyQt5 specific -- but rather depends on the underlying Qt version. (Works on 5.12, broken on 5.13).

Screenshot

asch99 · 2019-10-04T17:09:37Z

This issue can be fixed by adding one line in style.qss and recompiling:
add the line

  height: 12px;

to QComboBox::item:checked

so it reads

QComboBox::item:checked {
  font-weight: bold;
  height: 12px;
}

Do you want a PR for this? And if so, a PR with just this modified file, or do you want all recompiled rc files too?

cculianu · 2019-10-04T19:14:03Z

On Mojave with PyQt5 5.13.1 this still happens -- but with this fix it does not. Note that 14px for me looks better. But 12px is pretty good too.

Consider adding this or something similar ...

tanimislam · 2019-11-07T05:56:37Z

I also see thiis issue with the PyQt5 style sheet. Also the fix by @asch99 regarding this issue does not seem to work for the PyQt5 style sheet.

dpizetta · 2019-11-19T14:19:42Z

@goanpeca could you take a look at that? Tks

goanpeca · 2019-11-19T14:30:50Z

Will do!

QComboBoxes are a headache to style right :-| !

dpizetta · 2019-11-19T14:32:48Z

I see :( Thank you!

mikeleppane · 2019-11-26T20:56:02Z

I was also having this same problem with QComboBox. First I tried adding that height property like @asch99 recommended. I could not get it to work. Then I tried that original solution what @goanpeca suggested which is setting that styled delegate to ComboBox. That solution worked perfectly for me!

My environment is as follows:

QDarkStyle: 2.7
OS: Linux Ubuntu 18.04.3 LTS
Python: 3.6.8
PyQt5: 5.13.0
Qt: 5.13.0

asch99 · 2019-11-26T21:37:06Z

Yeah, I agree that my proposed solution does not seems to be the one-fix-for-all solution. What works reliably (so far) for me is to either modify the stylesheet of the combobox itself, or of the parent container.

E.g. having an QApplication with a QTabWidget, containing (as a tab) a QWidget, containing a QComboBox then modifying the stylesheet of the QWidget or the QCombobox fixes the problem. However, modifying the stylesheet of the QApplication does not fix the problem.

The applied modification is:
WIDGET_NAME.setStyleSheet(
"""
QComboBox::item:checked {
height: 12px;
border: 1px solid #32414B;
margin-top: 0px;
margin-bottom: 0px;
padding: 4px;
padding-left: 0px;
}
"""
)
where you have to use the actual widget name of your own widget.

The delegate solution also works, but then you loose part of the qdarkstyle formatting.

dpizetta · 2020-01-13T18:48:01Z

@goanpeca some news about this one? Sorry for my lack of communication, now I want to run with these changes as I have a time. Thanks

goanpeca · 2020-01-13T21:14:05Z

Not much :-|

dpizetta · 2020-01-20T01:57:57Z

I changed this to next version, so we can release the 2.8 :)

Daguerreo · 2020-03-10T10:30:48Z

Yeah, I agree that my proposed solution does not seems to be the one-fix-for-all solution. What works reliably (so far) for me is to either modify the stylesheet of the combobox itself, or of the parent container.

E.g. having an QApplication with a QTabWidget, containing (as a tab) a QWidget, containing a QComboBox then modifying the stylesheet of the QWidget or the QCombobox fixes the problem. However, modifying the stylesheet of the QApplication does not fix the problem.

The applied modification is:
WIDGET_NAME.setStyleSheet(
"""
QComboBox::item:checked {
height: 12px;
border: 1px solid #32414B;
margin-top: 0px;
margin-bottom: 0px;
padding: 4px;
padding-left: 0px;
}
"""
)
where you have to use the actual widget name of your own widget.

The delegate solution also works, but then you loose part of the qdarkstyle formatting.

This worked for me on Linux Slackware 14.2, QDarkStyle 2.8 and Qt 5.14.1

tanimislam · 2020-05-20T02:01:30Z

qmodern does not have the failing QComboBox with PyQt5. Its own dark mode looks as good as this module. Perhaps we should use that instead?

dpizetta · 2021-03-13T03:06:50Z

@jkulskis @tanimislam @mikeleppane Could you please check if the current solution in development works for everybody?

SomberNight · 2021-03-13T12:07:41Z

@dpizetta I have tested on a config where I could previously reproduce and can confirm the develop branch fixed this issue.
However there is now another issue, which might be related; for that I opened #263

vrot2000 · 2023-11-23T21:19:40Z

Same thing in Ubuntu under QT until 6.6.0
Fix:
QComboBox::item:checked { /*font-weight: bold;*/ height: 11px; }

m3nu mentioned this issue Jul 12, 2019

Oversized profile selection drop down borgbase/vorta#326

Closed

asch99 added a commit to asch99/QDarkStyleSheet that referenced this issue Oct 4, 2019

add height to QComboBox::item:checked, fixes ColinDuquesnoy#200

841fd07

dpizetta assigned dpizetta and goanpeca and unassigned dpizetta Jan 9, 2020

dpizetta added the bug label Jan 9, 2020

dpizetta added this to the 2.8 milestone Jan 13, 2020

Admiral-Fish mentioned this issue Jan 16, 2020

drop down UIs are broken on macOS Mojave (QDarkStyle) Admiral-Fish/RaidFinder#23

Closed

dpizetta modified the milestones: 2.8, 2.9 Jan 20, 2020

m3nu mentioned this issue Apr 21, 2020

Issue/200/dark mode dropdown borgbase/vorta#448

Merged

SomberNight mentioned this issue Jun 28, 2020

dark theme issues: dark text on dark background, dropdowns too large spesmilo/electrum#6281

Closed

xhargh mentioned this issue Sep 28, 2020

Dark theme variar/klogg#129

Closed

ljjh20 mentioned this issue Feb 24, 2021

Combo box dropdown size Linux/Mac czbiohub-sf/coPylot#38

Closed

dpizetta added a commit that referenced this issue Mar 13, 2021

Fix combobox selected item height, fix #200 #259

2dd3a9f

dpizetta mentioned this issue Mar 13, 2021

QComboBox, first selectable item takes too much space #259

Closed

ccordoba12 modified the milestones: 2.9, 3.0 Mar 15, 2021

dpizetta closed this as completed Mar 29, 2021

Gabsha mentioned this issue May 28, 2021

QComboBox expands selected item #282

Closed

SomberNight mentioned this issue Nov 17, 2021

Update qdarkstyle to <3.1 spesmilo/electrum#7561

Merged

SHF101202021 mentioned this issue May 22, 2024

Unexpected indentation for items in combobox #354

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QComboBox expands the last chosen item #200

QComboBox expands the last chosen item #200

jkulskis commented Jul 12, 2019 •

edited

Loading

goanpeca commented Jul 12, 2019

jkulskis commented Jul 12, 2019 •

edited

Loading

goanpeca commented Jul 12, 2019

jkulskis commented Jul 12, 2019

cculianu commented Aug 17, 2019

asch99 commented Oct 4, 2019

cculianu commented Oct 4, 2019

tanimislam commented Nov 7, 2019 •

edited

Loading

dpizetta commented Nov 19, 2019

goanpeca commented Nov 19, 2019

dpizetta commented Nov 19, 2019

mikeleppane commented Nov 26, 2019

asch99 commented Nov 26, 2019 •

edited

Loading

dpizetta commented Jan 13, 2020 •

edited

Loading

goanpeca commented Jan 13, 2020

dpizetta commented Jan 20, 2020

Daguerreo commented Mar 10, 2020

tanimislam commented May 20, 2020

dpizetta commented Mar 13, 2021

SomberNight commented Mar 13, 2021

vrot2000 commented Nov 23, 2023

QComboBox expands the last chosen item #200

QComboBox expands the last chosen item #200

Comments

jkulskis commented Jul 12, 2019 • edited Loading

Describe Your Environment

Language

Description / Steps to Reproduce [if necessary]

goanpeca commented Jul 12, 2019

jkulskis commented Jul 12, 2019 • edited Loading

goanpeca commented Jul 12, 2019

jkulskis commented Jul 12, 2019

cculianu commented Aug 17, 2019

Screenshot

asch99 commented Oct 4, 2019

cculianu commented Oct 4, 2019

tanimislam commented Nov 7, 2019 • edited Loading

dpizetta commented Nov 19, 2019

goanpeca commented Nov 19, 2019

dpizetta commented Nov 19, 2019

mikeleppane commented Nov 26, 2019

asch99 commented Nov 26, 2019 • edited Loading

dpizetta commented Jan 13, 2020 • edited Loading

goanpeca commented Jan 13, 2020

dpizetta commented Jan 20, 2020

Daguerreo commented Mar 10, 2020

tanimislam commented May 20, 2020

dpizetta commented Mar 13, 2021

SomberNight commented Mar 13, 2021

vrot2000 commented Nov 23, 2023

jkulskis commented Jul 12, 2019 •

edited

Loading

jkulskis commented Jul 12, 2019 •

edited

Loading

tanimislam commented Nov 7, 2019 •

edited

Loading

asch99 commented Nov 26, 2019 •

edited

Loading

dpizetta commented Jan 13, 2020 •

edited

Loading