Skip to content

Commit

Permalink
Bugfix: ensure search-bar keeps its height
Browse files Browse the repository at this point in the history
Adding a search-bar to a flex layout (e.g. search bar on top, iron-list below) squeezed the search-bar below its configured height. This was due to :host being styled with --layout-horizontal.
  • Loading branch information
Ronny Roeller committed Aug 23, 2017
1 parent 07a9e3a commit 0d54936
Showing 1 changed file with 20 additions and 14 deletions.
34 changes: 20 additions & 14 deletions paper-search-bar.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
<template>
<style>
:host {
display: block;
}

.horizontal-holder {
background: var(--background-color, white);
display: block;
padding: 0 16px;
Expand Down Expand Up @@ -73,21 +77,23 @@
}
</style>

<iron-icon icon="[[icon]]" class="icon"></iron-icon>
<iron-input bind-value="{{query}}">
<!-- Define is="iron-input" for backwards compatibility with Polymer 1.x -->
<input id="input" is="iron-input" placeholder="[[placeholder]]" value="{{value::input}}"></input>
</iron-input>

<template is="dom-if" if="{{query}}">
<paper-icon-button icon="clear" on-tap="_clear" class="icon"></paper-icon-button>
</template>
<template is="dom-if" if="{{!hideFilterButton}}">
<template is="dom-if" if="{{!disableFilterButton}}">
<paper-icon-button id="filter" icon="image:tune" on-tap="_filter" class="icon"></paper-icon-button>
<div class="horizontal-holder">
<iron-icon icon="[[icon]]" class="icon"></iron-icon>
<iron-input bind-value="{{query}}">
<!-- Define is="iron-input" for backwards compatibility with Polymer 1.x -->
<input id="input" is="iron-input" placeholder="[[placeholder]]" value="{{value::input}}"></input>
</iron-input>

<template is="dom-if" if="{{query}}">
<paper-icon-button icon="clear" on-tap="_clear" class="icon"></paper-icon-button>
</template>
<template is="dom-if" if="{{!hideFilterButton}}">
<template is="dom-if" if="{{!disableFilterButton}}">
<paper-icon-button id="filter" icon="image:tune" on-tap="_filter" class="icon"></paper-icon-button>
</template>
<paper-badge for="filter" label="[[nrSelectedFilters]]" class="badge" invisible$="[[!nrSelectedFilters]]"></paper-badge>
</template>
<paper-badge for="filter" label="[[nrSelectedFilters]]" class="badge" invisible$="[[!nrSelectedFilters]]"></paper-badge>
</template>
</div>
</template>
</dom-module>

Expand Down

0 comments on commit 0d54936

Please # to comment.