Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve naming of the _lottieFilePath field in LottieFileProcessor. #330

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Improve naming of the _lottieFilePath field in LottieFileProcessor. #330

merged 2 commits into from
Aug 6, 2020

Conversation

simeoncran
Copy link
Contributor

In response to a CR of another change.

@simeoncran simeoncran requested a review from a team as a code owner August 5, 2020 20:50
derobinsMSFT
derobinsMSFT approved these changes Aug 6, 2020
View reviewed changes
Copy link

@derobinsMSFT derobinsMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simeoncran simeoncran merged commit d8417f9 into master Aug 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the FileToFilePathNaming branch August 6, 2020 18:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@derobinsMSFT derobinsMSFT derobinsMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simeoncran @derobinsMSFT