Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show animator counts in the object status table in generated code. #343

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

simeoncran
Copy link
Contributor

@simeoncran simeoncran commented Aug 31, 2020

We were showing the number of animation objects previously, but that doesn't really tell you how expensive animations are in DWM because the one animation might be started multiple times. Animator counts are a better representation of cost.

Here's an example of the extra info. Note the animators, and parameters counts.

// |       Object stats       | UAP v12 count | UAP v8 count |
// |__________________________|_______________|______________|
// | All CompositionObjects   |           567 |          567 |
// |--------------------------+---------------+--------------|
// | Expression animators     |            51 |           51 |
// | KeyFrame animators       |            50 |           50 |
// | Reference parameters     |            51 |           51 |
// |--------------------------+---------------+--------------|
// | Animated brushes         |             1 |            1 |

We were showing the number of animation objects previously, but that doesn't really tell you how expensive animations are in DWM because the one animation might be started multiple times. Animator counts are a better representation of cost.
@simeoncran simeoncran requested a review from a team as a code owner August 31, 2020 17:34
Copy link

@derobinsMSFT derobinsMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simeoncran simeoncran merged commit 62f5778 into master Aug 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the ReportAnimatorCounts branch August 31, 2020 20:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants