Improvements for CppWinrt on Win32. #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code we were generating for cppwinrt had a couple issues when compiled for Win32 (vs UWP). 1. It included a file that cppwinrt doesn't generate for Win32. 2. It was relying on Windows.Foundation.Collections.h being included by something else.
| // {_cppwinrtGeneratedFileNameBase}.cpp is needed for UWP, but is not usually generated by | ||
| // "cppwinrt for WIN32 apps. The file is related to how cppwinrt makes types activatable. | ||
| // If the file exists, we'll include it. | ||
| builder.WriteLine($"#if __has_include(\"{_cppwinrtGeneratedFileNameBase}.cpp\")"); |
There was a problem hiding this comment.
__has_include [](start = 36, length = 13)
Wow, learn something new every day
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code we were generating for cppwinrt had a couple issues when compiled for Win32 (vs UWP).