[LottieViewer] PixelView bug fixed. We should not update pixel view when it is not on the screen. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen it is not on the screen.
leonardoblanco-ms
approved these changes
Oct 14, 2021
delete-merged-branch
bot
deleted the
user/aborziak/fixed-pixel-view-bug
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this bug PixelView generated a lot of exceptions that were not visible to the user but slowed down the LottieViewer. We should update PixelView only when it is open on the screen, otherwise we will get an exception because we are trying to update the surface that is not visible.