[LottieGen] Added workaround to make path animations playable even with different number of segments in keyframes #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number of segments in keyframes
|
Added warning if this state is detected |
aborziak-ms
force-pushed
the
path-animation-fix
branch
from
966cf86
to
7dda12e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some animations can't be played in Lottie-Windows because of WinComp Api limitation: number of segments in path animation should be the same for all keyframes, but After Effects supports animation with any number of segments.
Added a workaround to make number of segments equal for all the keyframes by adding 0-length segments to the path at the end. It may result in a little bit different animation from what you see in After Effects.
#493