Skip to content

Sample App Final Build #214

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Sep 2, 2023
Merged

Sample App Final Build #214

merged 8 commits into from
Sep 2, 2023

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Sep 1, 2023

Fixes #197
Supersedes CommunityToolkit/Tooling-Windows-Submodule#134

Supports #195

This addresses a number of Sample App / Doc things for our final build:

PORTS AttachedCardShadow - Somehow we missed this!?!?! Phew... - For #35

@michael-hawker michael-hawker changed the title Llama/fix sample loading Sample App Final Build Sep 1, 2023
… app

We should think of making an analyzer to detect this, since we use it...
See discussion here about this issue: CommunityToolkit/Tooling-Windows-Submodule#134 (comment)
…l port somehow!

Tested on UWP, should work on WASDK, but needs test...
Updated namespace, and did null work - Otherwise should be no changes from UWP main source of old repo
Moves AttachedCardShadow doc to the Media Samples
Move AttachedDropShadow samples to their own folder
@michael-hawker
Copy link
Member Author

Filed #215 for Markdown display issues

@michael-hawker michael-hawker marked this pull request as ready for review September 2, 2023 02:17
@michael-hawker michael-hawker enabled auto-merge (rebase) September 2, 2023 02:17
@michael-hawker michael-hawker merged commit 3217d31 into main Sep 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the llama/fix-sample-loading branch September 2, 2023 02:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C#/XAML code not showing (UWP)
2 participants