Skip to content

Enhance tokenizing text box #261

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

minesworld
Copy link

Fixes #256 #259 #257

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Other... Enhancing the possible usage of the TokenizingTextBox by giving the programmer more control over the AutoSuggestBox

What is the current behavior?

TokenDelimiter are only handled if it consists of a single character ( #257 )

What is the new behavior?

TokenDelimiter of any length are handled correctly ( #257 )
More control over the behaviour of the TokenizingTextBox ( #256 #259 )

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [x ] Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • [ x] Contains NO breaking changes

Other information

@minesworld
Copy link
Author

A litte warning about the requed - have disabled the tracking of some files to prevent them being commited [d3cdd7e] ...

@minesworld
Copy link
Author

minesworld commented Oct 20, 2023 via email

@niels9001 niels9001 requested a review from Arlodotexe November 21, 2023 14:34
@Arlodotexe Arlodotexe added the enhancement New feature or request label Jan 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Make TokenizingTextBox more flexible
3 participants