Skip to content

Added CenterHorizontally and CenterVertically to the ListView Extensions | Smooth Scroll Into View #648

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HotCakeX
Copy link
Contributor

@HotCakeX HotCakeX commented Feb 28, 2025

Added CenterHorizontally and CenterVertically for the ListView Extensions, Smooth Scrolling Into View

Fixes

Fixes this issue: #647

PR Type

  • Bugfix

What is the current behavior?

Smooth Scroll Into View has a Center behavior that centers the ListView both horizontally and vertically at the same time.

What is the new behavior?

The 2 new behaviors allow for only centering horizontally or only centering vertically.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

Talked about this with @michael-hawker on Discord

Added CenterHorizontally and CenterVertically

Fixes this issue: CommunityToolkit#647
@michael-hawker michael-hawker marked this pull request as draft February 28, 2025 17:31
@michael-hawker
Copy link
Member

Thanks @HotCakeX, marking this as a draft for now. I think we should breakdown the changes/uses of the new scenario on the API surface a bit more. Let's chat in the issue more.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants