-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add and use new EquatableArray<T> type in source generators #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24197cd
to
c07d1c9
Compare
5449a48
to
6639473
Compare
f29d75c
to
d033938
Compare
Merging this, as it's just the same pattern also used in ComputeSharp and other generators too at this point 🙂 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
improvements ✨
Improvements to an existing functionality
maintenance ⚙️
Some regular maintenance updates
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
optimization ☄
Performance or memory usage improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
EquatableArray<T>
type and uses it to greatly simplify all source generator incremental models.See: dotnet/runtime#77183 (comment).
PR Checklist