Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add and use new EquatableArray<T> type in source generators #469

Merged
merged 15 commits into from
Oct 25, 2022

Conversation

Sergio0694
Copy link
Member

This PR adds a new EquatableArray<T> type and uses it to greatly simplify all source generator incremental models.

See: dotnet/runtime#77183 (comment).

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality maintenance ⚙️ Some regular maintenance updates optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Oct 19, 2022
@Sergio0694 Sergio0694 requested a review from Arlodotexe October 19, 2022 22:03
@Sergio0694 Sergio0694 marked this pull request as draft October 19, 2022 22:16
@Sergio0694 Sergio0694 marked this pull request as ready for review October 19, 2022 23:37
@Sergio0694
Copy link
Member Author

Merging this, as it's just the same pattern also used in ComputeSharp and other generators too at this point 🙂

@Sergio0694 Sergio0694 merged commit 820a55e into main Oct 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/equatable-array branch October 25, 2022 14:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvements ✨ Improvements to an existing functionality maintenance ⚙️ Some regular maintenance updates mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant