fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.3 #423
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Hi @renovate[bot]. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is going to require some changes to the code since it appears there is a breaking change from 0.16.1 to 0.16.2. |
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/sigs.k8s.io-controller-runtime-0.x
branch
from
0db8d66 to
9d21958
Compare
renovate
bot
changed the title
renovate
bot
changed the title
The fake client we use in our unit tests was recently updated to be more inline with what the actual kubernetes API does: kubernetes-sigs/controller-runtime#2259 As a result, some of our tests broken because we were lumping Status and other updates into the same Update() request. This commit refactors those tests so that Status updates are implemented separately from the rest of the runtime objects. We need to do this before we can upgrade controller-runtime to 0.16.3.
A recent dependency bump (controller-runtime 0.16.1 to 0.16.3) requires golang 1.20.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
| err := reconciler.Client.Status().Update(context.TODO(), compliancescaninstance) | ||
| Expect(err).To(BeNil()) | ||
| compliancescaninstance.Spec.Debug = true | ||
| err = reconciler.Client.Update(context.TODO(), compliancescaninstance) |
There was a problem hiding this comment.
Splitting this into two updates was necessary because of recent changes to fake client:
|
Attempting to update golang version in openshift/release#44853 |
|
This should be ready for a recheck when openshift/release#44853 merges |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: renovate[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
deleted the
renovate/sigs.k8s.io-controller-runtime-0.x
branch
This PR contains the following updates:
v0.16.1->v0.16.3Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.16.3Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.16.2...v0.16.3
v0.16.2Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.16.1...v0.16.2
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.