OCPBUGS-38312: Add auto-remediation for rule service_systemd-coredump_disabled #13259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojiey
force-pushed
the
fix-OCPBUGS-38312
branch
from
fc55a0e to
08a502e
Compare
|
@xiaojiey Please fill the PR description. |
xiaojiey
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
xiaojiey
force-pushed
the
fix-OCPBUGS-38312
branch
from
08a502e to
ba5e922
Compare
xiaojiey
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-rhcos4-moderate |
|
@xiaojiey: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tested with 4.19.0-0.nightly-2025-03-30-191359, I can see the auto-remediation applied and return PASS |
xiaojiey
force-pushed
the
fix-OCPBUGS-38312
branch
from
ba5e922 to
99320ea
Compare
xiaojiey
force-pushed
the
fix-OCPBUGS-38312
branch
from
99320ea to
8cb88e5
Compare
Update e2e test results
xiaojiey
force-pushed
the
fix-OCPBUGS-38312
branch
from
8cb88e5 to
8fb170f
Compare
|
/test 4.18-e2e-aws-rhcos4-moderate |
|
/test e2e-aws-rhcos4-moderate |
|
/test e2e-aws-rhcos4-high |
|
/test 4.12-e2e-aws-rhcos4-high |
|
Code Climate has analyzed commit 8fb170f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add auto-remediation for rule service_systemd-coredump_disabled
Rationale:
The rule rule service_systemd-coredump_disabled with below machineconfig for ocp:
`apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
spec:
config:
ignition:
version: 3.1.0
systemd:
units:
enabled: false
mask: true
enabled: false
mask: true`
Review Hints: