Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Update multi-platform and remove oval.config usage #2430

Closed

Conversation

redhatrises
Copy link
Contributor

@redhatrises redhatrises commented Oct 23, 2017

Description:

  • Allow usage of short names e.g. rhel7 or long names e.g. Red Hat Enterprise Linux 7
  • Add product currently being built instead of all products for multi-platform OVAL
  • Remove usage of oval.config

Rationale:

  • Use of multi_platform is a bit unwieldy.

- Allow usage of short names e.g. rhel7 or long names e.g. Red Hat Enterprise Linux 7
- Add product currently being built instead of all products for multi-platform OVAL
- Remove usage of oval.config
@redhatrises redhatrises changed the title Update multi-platform and remove oval.config usage [WIP] Update multi-platform and remove oval.config usage Oct 23, 2017
@redhatrises
Copy link
Contributor Author

This doesn't currently handle non-versioned products (e.g. fedora, opensuse, etc.); however, I want to get some thoughts on this PR. For non-versioned products like Fedora we could use dicts/lists in map_product_module.py or just use dicts/lists for all products.... This PR takes into account the product version from args.product in combine-ovals.py

@yuumasato
Copy link
Member

Ok, it took me a while to understand how oval.config would not be necessary anymore.

We receive product|version from CMake build, and if we are adding platform element just for current product on build, then we know everything we need and there is no need to keep track of all versions of a product.

For non-versioned products, we should probably extract version information from their cpe dictionaries, i.e.: fedora/cpe/fedora-cpe-dictionary.xml and opensuse/cpe/opensuse-cpe-dictionary.xml. This is most likely the place with updated versions.

@redhatrises
Copy link
Contributor Author

I am going to close this as this has fallen onto the back burner. I don't think reading CPEs are the best either if the build system can handle it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants