Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove overly restrictive FIPS checks #4920

Conversation

chuckatkins
Copy link
Contributor

@chuckatkins chuckatkins commented Oct 11, 2019

Description:

  • This removes the OS FIPS certification check from testing the FIPS related configuration of various individual components.

Rationale:

  • Whether or not a package is configured to use FIPS approved crypto algorithms and hashes or fips-related packages are installed is orthogonal to whether or not the installed operating system is FIPS certified. Whether or not the OS is FIPS certified still remains a stand alone rule by itself and should continue to be used in environments where necessary.

  • Fixes Excessive FIPS checks #4917

Whether or not a package is configured to use FIPS approved crypto
algorithms and hashes or fips-related packages are installed is orthogonal
to whether or not the installed operating system is FIPS certified.  This
removes the OS certification test from the configuration checks for
individual components.  Whether or not the OS is FIPS certified still
remains a stand alone rule by itself and should continue to be used in
environments where necessary.
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@redhatrises
Copy link
Contributor

Sorry but NACK. FIPS cipher checks are required to meet FIPS validated ciphers of which CentOS is not FIPS validated.

@redhatrises
Copy link
Contributor

Specifically NIST 800-53 SI-1 and SC-13 in accordance with applicable federal laws, Executive Orders, directives, policies, regulations, and standards.

@jamescassell
Copy link
Contributor

This same issue causes all new point releases of RHEL to fail all fips rules until DISA adds the most recent version to the "supported" list... lots of false positives.

@chuckatkins
Copy link
Contributor Author

chuckatkins commented Oct 11, 2019

Aren't the rules in question though just supposed to be checking that "only fips approved ciphers are being used", not "only fips approved ciphers are being used on a fips certified os"? Forgetting about RHEL derivatives for the moment, developing content for other distros, you'd still want to be able to test the crypto configuration regardless of whether or not the os is certified. There's already a separate rule that covers whether the os is approved or not. So doesn't it make sense then for the profiles to include all the fips related rules and the ones checking technical configuration should be able to pass on any distro if configured appropriately while the "os is certified" would always fail unless rhel proper at a certified minor release?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive FIPS checks
4 participants