add a isNaN function for integers #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @brief this allows the use of isnan() for unsigned | ||
| * in the template function fileToVector() | ||
| */ | ||
| inline bool isnan(unsigned i){ |
- on some compilers, isnan(int) was not defined and would cause compile errors - now, isnan(const int) and isnan(const unsigned) return false, which is always correct - everything is const as ***
slizzered
force-pushed
the
fix-isnan_for_int
branch
from
1c3dacb to
66e4e81
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isnan(int)was not defined and would cause compileerrors
isnan(int)andisnan(unsigned)returnfalse, which is alwayscorrect