Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for changing the Voigt implementation #51

Merged
merged 4 commits into from
Dec 10, 2022
Merged

Conversation

ConorMacBride
Copy link
Owner

When initialising the IBIS8542Model, a impl kwarg can now be passed to specify the function used to evaluate the Voigt function. The Faddeeva Voigt function is also added, using the SciPy implementation, however, the default implementation remains the integration method such that the code is fully backwards compatible.

Also, additional kwargs passed to the fit method are now passed through to SciPy curve_fit, which allows for the least squares configuration to be changed with ease.

@ConorMacBride ConorMacBride added the enhancement New feature or request label Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #51 (1641217) into main (810d864) will decrease coverage by 0.05%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   95.07%   95.02%   -0.06%     
==========================================
  Files          18       18              
  Lines        1382     1367      -15     
==========================================
- Hits         1314     1299      -15     
  Misses         68       68              
Impacted Files Coverage Δ
src/mcalf/models/base.py 84.87% <50.00%> (ø)
src/mcalf/models/ibis.py 92.12% <100.00%> (+0.14%) ⬆️
src/mcalf/profiles/voigt.py 96.10% <100.00%> (-0.74%) ⬇️
src/mcalf/visualisation/spec.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ConorMacBride ConorMacBride merged commit 997cd08 into main Dec 10, 2022
@ConorMacBride ConorMacBride deleted the voigt-impl branch March 16, 2023 21:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant