Support for changing the Voigt implementation #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initialising the IBIS8542Model, a
impl
kwarg can now be passed to specify the function used to evaluate the Voigt function. The Faddeeva Voigt function is also added, using the SciPy implementation, however, the default implementation remains the integration method such that the code is fully backwards compatible.Also, additional kwargs passed to the
fit
method are now passed through to SciPy curve_fit, which allows for the least squares configuration to be changed with ease.