Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change default Voigt implementation to voigt_faddeeva #52

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

ConorMacBride
Copy link
Owner

This PR changes the default Voigt implementation from voigt_integrate to voigt_faddeeva because it is much more efficient and sufficiently accurate.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #52 (4e7dcea) into main (997cd08) will decrease coverage by 0.17%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   95.02%   94.86%   -0.17%     
==========================================
  Files          18       18              
  Lines        1367     1362       -5     
==========================================
- Hits         1299     1292       -7     
- Misses         68       70       +2     
Impacted Files Coverage Δ
src/mcalf/models/base.py 84.25% <ø> (-0.62%) ⬇️
src/mcalf/models/results.py 100.00% <ø> (ø)
src/mcalf/utils/plot.py 100.00% <ø> (ø)
src/mcalf/utils/smooth.py 100.00% <ø> (ø)
src/mcalf/profiles/voigt.py 95.83% <71.42%> (-0.28%) ⬇️
src/mcalf/models/ibis.py 92.12% <100.00%> (ø)
src/mcalf/visualisation/spec.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ConorMacBride ConorMacBride merged commit 2062729 into main Mar 17, 2023
@ConorMacBride ConorMacBride deleted the default-voigt branch March 17, 2023 13:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant