Fix log of line counts in case of block limit reached + minor changes #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
delehef
approved these changes
Jan 19, 2024
powerslider
pushed a commit
that referenced
this pull request
Jan 22, 2024
…#555) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we hit one of the module limits, then the summary log at the end is wrong since it contains also the last not selected tx, we just need to use prevCumulatedLineCount instead of currCumulatedLineCount, since it the var that contains the counts of the selected txs. prevCumulatedLineCount renamed to consolidatedCumulatedLineCount to reflect that.