Fix log of line counts in case of block limit reached + minor changes

arithmetization/src/main/java/net/consensys/linea/sequencer/txselection/selectors/LineaTransactionSelector.java

@@ -31,8 +31,8 @@
 @Slf4j
 public class LineaTransactionSelector implements PluginTransactionSelector {
 
-  private static TraceLineLimitTransactionSelector traceLineLimitTransactionSelector;
-  List<PluginTransactionSelector> selectors;
+  private TraceLineLimitTransactionSelector traceLineLimitTransactionSelector;
+  private List<PluginTransactionSelector> selectors;
 
   public LineaTransactionSelector(
       LineaTransactionSelectorConfiguration lineaConfiguration,
@@ -47,7 +47,7 @@ public LineaTransactionSelector(
    * @param limitsMapSupplier The supplier for the limits map.
    * @return A list of selectors.
    */
-  private static List<PluginTransactionSelector> createTransactionSelectors(
+  private List<PluginTransactionSelector> createTransactionSelectors(
       final LineaTransactionSelectorConfiguration lineaConfiguration,
       final Supplier<Map<String, Integer>> limitsMapSupplier) {
 

arithmetization/src/main/java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java

@@ -69,7 +69,7 @@ public TransactionSelectionResult evaluateTransactionPostProcessing(
 
       if (margin < minMargin) {
         log(
-            log.atInfo(),
+            log.atDebug(),
             transaction,
             margin,
             effectiveGasPrice,

arithmetization/src/main/java/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java

@@ -47,7 +47,7 @@ public class TraceLineLimitTransactionSelector implements PluginTransactionSelec
   private final ZkTracer zkTracer;
   private final String limitFilePath;
   private final Map<String, Integer> moduleLimits;
-  private Map<String, Integer> prevCumulatedLineCount = Map.of();
+  private Map<String, Integer> consolidatedCumulatedLineCount = Map.of();
   private Map<String, Integer> currCumulatedLineCount;
 
   public TraceLineLimitTransactionSelector(
@@ -81,7 +81,7 @@ public void onTransactionNotSelected(
   public void onTransactionSelected(
       final TransactionEvaluationContext<? extends PendingTransaction> evaluationContext,
       final TransactionProcessingResult processingResult) {
-    prevCumulatedLineCount = currCumulatedLineCount;
+    consolidatedCumulatedLineCount = currCumulatedLineCount;
   }
 
   /**
@@ -120,7 +120,7 @@ public TransactionSelectionResult evaluateTransactionPostProcessing(
 
       final int cumulatedModuleLineCount = currCumulatedLineCount.get(module);
       final int txModuleLineCount =
-          cumulatedModuleLineCount - prevCumulatedLineCount.getOrDefault(module, 0);
+          cumulatedModuleLineCount - consolidatedCumulatedLineCount.getOrDefault(module, 0);
 
       if (txModuleLineCount > moduleLineCountLimit) {
         log.warn(
@@ -158,7 +158,7 @@ private String logTxLineCount() {
                 // tx line count / cumulated line count / line count limit
                 e.getKey()
                     + "="
-                    + (e.getValue() - prevCumulatedLineCount.getOrDefault(e.getKey(), 0))
+                    + (e.getValue() - consolidatedCumulatedLineCount.getOrDefault(e.getKey(), 0))
                     + "/"
                     + e.getValue()
                     + "/"
@@ -177,12 +177,10 @@ public void traceEndBlock(final BlockHeader blockHeader, final BlockBody blockBo
           .addKeyValue(
               "traceCounts",
               () ->
-                  currCumulatedLineCount == null
-                      ? "null"
-                      : currCumulatedLineCount.entrySet().stream()
-                          .sorted(Map.Entry.comparingByKey())
-                          .map(e -> '"' + e.getKey() + "\":" + e.getValue())
-                          .collect(Collectors.joining(",")))
+                  consolidatedCumulatedLineCount.entrySet().stream()
+                      .sorted(Map.Entry.comparingByKey())
+                      .map(e -> '"' + e.getKey() + "\":" + e.getValue())
+                      .collect(Collectors.joining(",")))
           .log();
     }
   }