Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SIS to BLS12-377 #470

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Add SIS to BLS12-377 #470

merged 2 commits into from
Dec 14, 2023

Conversation

AlexandreBelling
Copy link
Collaborator

Description

This Pull Request implements SIS hashing on the scalar field of the BLS12-377. The structure of the folder is made to be identical to the structure of the one for the BN254 scalar field. The only part that is quite not identical are the comments. The features are been implemented essentially through copy-pasting and adapting the constants.

This will be required as we are planning to swap the inner-proof to this particular field.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

All the tests have been ported, including the test-vector generation in sage.

How has this been benchmarked?

All the benchmark have been ported, the results are essentially identical to those for the BN254 curve

@AlexandreBelling AlexandreBelling self-assigned this Dec 4, 2023
@gbotrel gbotrel merged commit ac0e875 into master Dec 14, 2023
7 checks passed
@gbotrel gbotrel deleted the alex/add-sis-to-bls12377 branch December 14, 2023 21:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants