Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: sis limb-decomposition works with log-two_bound > 8 #512

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

AlexandreBelling
Copy link
Collaborator

Description

LimbDecompose would not work correctly if the logTwoBound is larger than 8 and would silently skips the input bits corresponding to any bytes coming after the first in every limb.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlexandreBelling AlexandreBelling added the bug Something isn't working label Jun 23, 2024
@AlexandreBelling AlexandreBelling self-assigned this Jun 23, 2024
@ThomasPiellard ThomasPiellard merged commit 1ef1276 into master Jun 24, 2024
7 checks passed
@ivokub ivokub deleted the fix/sis-issue-when-logTwoBound-larger-than-8 branch June 25, 2024 07:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants