Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support stateful block tx selectors #140

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 5, 2025

This PR adapts the plugin transaction selectors to the new generic way of supporting their internal state via the SelectorsStateManager in Besu PR hyperledger/besu#8268

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…ck-tx-selectors

# Conflicts:
#	gradle.properties
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/MaxBlockCallDataTransactionSelector.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/MaxBlockGasTransactionSelector.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java
@fab-10 fab-10 force-pushed the support-stateful-block-tx-selectors branch from 636002d to 17d1d96 Compare February 11, 2025 13:11
# Conflicts:
#	gradle.properties
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/MaxBlockCallDataTransactionSelector.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/MaxBlockGasTransactionSelector.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java
@fab-10 fab-10 force-pushed the support-stateful-block-tx-selectors branch from 199ae37 to 2b82583 Compare February 11, 2025 14:24
@fab-10 fab-10 marked this pull request as ready for review February 11, 2025 17:14
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - som suggestions on comments

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 merged commit 528ce54 into Consensys:main Feb 13, 2025
4 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants