Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Linea send bundle #142

Merged
merged 34 commits into from
Feb 14, 2025
Merged

Linea send bundle #142

merged 34 commits into from
Feb 14, 2025

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 13, 2025

plugin for linea_sendBundle, endpoints:

linea_sendBundle implements eth_sendBundle interface
linea_cancelBundle implements eth_cancelBundle interface

New configuration options:

  • plugin-linea-max-bundle-pool-size-bytes (default: 16777216) Sets max memory size, in bytes, that the bundle txpool can occupy
  • plugin-linea-max-bundle-block-gas (default: 15000000) Sets max amount of block gas bundle transactions can use

Notably linea_sendBundle does not implement any behavior for builders .

example usages:
linea_sendBundle:

curl --location 'http://localhost:8545' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc":"2.0",
    "method":"linea_sendBundle",
    "params":[
        {
        "txs": [
         "0xf84f01821388825208800480820a96a05e69dba6b4413db2df32614646adf27c5774bf49c69ce6fef7a82df426514541a0754f79cba2c3353338496c2ccce98a4457e1ca0b6de4e79456e6619a9832a9e7"],
        "blockNumber": "0x962FC1"
        }
        ],
    "id":1
}'

linea_cancelBundle:

curl --location 'http://localhost:8545' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc":"2.0",
    "method":"linea_cancelBundle",
    "params":["c00f29c8-9763-4254-93fe-88d217edddca"],
    "id":1
}'

garyschulte and others added 30 commits January 30, 2025 14:46
outstanding work on creating a shared singleton bundle pool before we can smoke test the endpoint.

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…ization issues

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…h_sendBundle-merge

# Conflicts:
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorFactory.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/LineaTransactionSelector.java
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
also to simplify assume that the bundle pool is always available.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# Conflicts:
#	acceptance-tests/src/test/resources/moduleLimits_sendRawTx.toml
#	acceptance-tests/src/test/resources/noModuleLimits.toml
#	acceptance-tests/src/test/resources/txOverflowModuleLimits.toml
#	gradle.properties
#	sequencer/src/main/java/net/consensys/linea/sequencer/modulelimit/ModuleLineCountValidator.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorFactory.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/LineaTransactionSelector.java
#	sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 mentioned this pull request Feb 13, 2025
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 merged commit 35030c8 into Consensys:main Feb 14, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants