Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update gradle test config to show better output #1021

Conversation

DavePearce
Copy link
Collaborator

This updates the gradle test configuration to generate better output during testing. In particular, so we can see why a particular test failed rather than just "FAILED". This will be helpful for both Rust corset and go-corset.

@DavePearce DavePearce linked an issue Aug 28, 2024 that may be closed by this pull request
@DavePearce DavePearce force-pushed the feat/issue-1020/improve-output-for-go-corset-in-github-action branch from 6193ea1 to 0064344 Compare August 28, 2024 14:58
@DavePearce DavePearce requested a review from FlorianHuc August 28, 2024 15:00
@DavePearce
Copy link
Collaborator Author

I wonder if makes sense to flip this to false as well:

    // set to false to hide passed standard out and error streams
    showPassedStandardStreams true

Since we only care about the output when the test fails?

@DavePearce DavePearce force-pushed the feat/issue-1020/improve-output-for-go-corset-in-github-action branch from 0064344 to 9c54342 Compare August 28, 2024 19:38
This updates the gradle test configuration to generate better output
during testing.  In particular, so we can see why a particular test
failed rather than just "FAILED".  This will be helpful for both Rust
`corset` and `go-corset`.
@DavePearce DavePearce force-pushed the feat/issue-1020/improve-output-for-go-corset-in-github-action branch from 9c54342 to 5cef869 Compare August 29, 2024 06:33
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@letypequividelespoubelles
Copy link
Collaborator

I wonder if makes sense to flip this to false as well:

    // set to false to hide passed standard out and error streams
    showPassedStandardStreams true

Since we only care about the output when the test fails?

I do agree, it would be easier to read if we print only failing test

@DavePearce
Copy link
Collaborator Author

Ok, will put that in place and see how it looks.

This disables standard streams from being printed for passing tests.
That should just reduce the clutter when a test is failing.
@DavePearce DavePearce force-pushed the feat/issue-1020/improve-output-for-go-corset-in-github-action branch from 62e4cae to a2b48b4 Compare August 29, 2024 07:35
@DavePearce DavePearce merged commit acc67a1 into arith-dev Aug 29, 2024
5 of 6 checks passed
@DavePearce DavePearce deleted the feat/issue-1020/improve-output-for-go-corset-in-github-action branch August 29, 2024 08:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve output for go-corset in Github Action
2 participants