Fix for BLOCKHASH conversion error
#1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts in place a simple fix for ensuring captured block hashes are for valid blocks relative to the current block.
DavePearce
force-pushed
the
fix/issue-1024/prevent-conversion-error-for-blockhash-in-blockcapturer
branch
from
4358d11 to
c0260e2
Compare
letypequividelespoubelles
approved these changes
Aug 28, 2024
| @@ -39,6 +38,10 @@ | |||
| import org.hyperledger.besu.plugin.data.BlockHeader; | |||
|
|
|||
| public class BlockCapturer implements ConflationAwareOperationTracer { | |||
| public static final int MAX_RELATIVE_BLOCK = 256; | |||
There was a problem hiding this comment.
you could use BLOCKHASH_MAX_HISTORY in GlobalConstants.java
There was a problem hiding this comment.
Well maybe at some point I'll put that in
DavePearce
deleted the
fix/issue-1024/prevent-conversion-error-for-blockhash-in-blockcapturer
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in place a simple fix for ensuring captured block hashes are for valid blocks relative to the current block. This is based on the implementation in BlockHashOperation.java