fix: precompiles are considered COLD when using BESU frame method #1079
Conversation
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
| @@ -88,16 +96,15 @@ private void stpCallForCalls(Hub hub) { | |||
| default -> throw new IllegalArgumentException( | |||
| "STP module triggered for a non CALL-type instruction"); | |||
| }; | |||
| this.warm = frame.isAddressWarm(to); | |||
| this.warm = frame.isAddressWarm(to) || isPrecompile(to); | |||
There was a problem hiding this comment.
the only non-formatting change
There was a problem hiding this comment.
That is a potentially a bug. Did you notice this with the ToyExecutionEnvironmentV2 or with replay tests @letypequividelespoubelles ?
There was a problem hiding this comment.
with replayTest, but the bug comes from a @FlorianHuc 's block with a BESU node
There was a problem hiding this comment.
The only thing I'm worried about now is in our tracing of account-rows: do we have to manually insert the warmth of precompiles @letypequividelespoubelles ? Given that Besu does not recognize precompiles as inherently warm.
Yes, Besu manually add the warmth of precompile when itr deals with calls : see https://github.com/hyperledger/besu/blob/65240fdf4697a81824048d453a0d9818c37c2c3d/evm/src/main/java/org/hyperledger/besu/evm/gascalculator/BerlinGasCalculator.java#L169 (TY @ahamlat ). I'll create a method and check that all usage of |
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
letypequividelespoubelles
deleted the
fix/issue-1067/some-more-CALL-issue
branch
No description provided.