Feat/issue 1026/gas complete implementation #1122
Conversation
|
I guess what is missing is the triggering. I expect that we can have the triggering happen in the |
arithmetization/src/main/java/net/consensys/linea/zktracer/module/gas/Gas.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/gas/Gas.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/gas/GasCall.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
.../main/java/net/consensys/linea/zktracer/module/hub/fragment/common/CommonFragmentValues.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/gas/GasOperation.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
.../main/java/net/consensys/linea/zktracer/module/hub/fragment/common/CommonFragmentValues.java
Outdated
Show resolved
Hide resolved
…com:Consensys/linea-tracer into feat/issue-1026/gas-complete-implementation
| public void call(GasCall gasCall, Hub hub, CommonFragmentValues commonValues) { | ||
| this.commonValues = commonValues; | ||
| this.gasCall = gasCall; | ||
| hub.defers().scheduleForPostExecution(this); |
There was a problem hiding this comment.
I find VERy weird to schedule for post exec teh GAS module and not the GasOperation ... Of course it works but .... strange.
There was a problem hiding this comment.
How would you do it to make it look more natural?
There was a problem hiding this comment.
I don't see any beautiful and nice way to do it wo copying duplicate info and add cross-link ... Let's keep it like this :)
| wcpRes[1] = true; | ||
| final boolean gasCostIsNonNegative = wcp.callLEQ(0, gasCall.getGasCost().longValue()); | ||
| wcpRes[1] = gasCostIsNonNegative; // true | ||
| checkArgument(gasCostIsNonNegative); |
There was a problem hiding this comment.
are the checkARgument really usefull ? It'll break on the constraint check anyway. It's making useless check imho
There was a problem hiding this comment.
You are right.
|
We have a failing constraint gas.asserting-either-sufficient-gas-or-insufficient-gas |
|
|
…com:Consensys/linea-tracer into feat/issue-1026/gas-complete-implementation
This reverts commit e1ef888.
No description provided.