feat: use .tmp file extension while writing a conflated trace in order to indicate that the trace is incomplete if it stays with the .tmp extension #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to indicate that the trace is incomplete if it stays with the .tmp extension
FlorianHuc
approved these changes
Sep 12, 2024
| // Write the trace at the original and final trace file path, but with the suffix .tmp at the | ||
| // end of the file. | ||
| final Path tmpTraceFilePath = | ||
| tracer.writeToTmpFile(tracesOutputPath, origTraceFileName + ".", TRACE_TEMP_FILE_EXTENSION); |
There was a problem hiding this comment.
don't we have a '.' too many?
I would have found it easier to follow with final_name = xxx-yyy.lt
and
temp_name = final_name + ".tmp"
There was a problem hiding this comment.
No, this dot is needed because Files.createTempFile(rootDir, prefix, suffix) appends . at the end and there is no dot symbol before the timestamp so with this approach I am setting the suffix to be .lt.tmp and the renamed file will end with only .lt. Here is a real example from my local testing:
// Temp file name
600-700.conflated.0.6.0-rc1.6783354941660875494.lt.tmp
// Final file name
600-700.conflated.0.6.0-rc1.lt
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.